Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: define targets in conftest.py, refactor devtools usages #1327

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Aug 5, 2023

The pytest-cases/etc test refactor demo'd in #1066 likely not worth the effort, I see no benefit over the current approach besides deduplicating test_mf6model() test functions

@wpbonelli wpbonelli force-pushed the test-target-config branch from c335635 to 8ad0b58 Compare August 5, 2023 05:35
@wpbonelli wpbonelli changed the title test: define targets in conftest.py, don't import from devtools test: define targets in conftest.py, refactor devtools usages Aug 5, 2023
* configure dict mapping exe names to paths in conftest.py instead of importing from devtools (to be removed)
* remove usages of Case (to be removed from devtools), refactor test_gwf_maw[1-4] to accommodate
@wpbonelli wpbonelli force-pushed the test-target-config branch from 8ad0b58 to 8c2bd0b Compare August 5, 2023 16:20
@wpbonelli wpbonelli marked this pull request as ready for review August 5, 2023 16:31
@wpbonelli wpbonelli merged commit 5d4f56a into MODFLOW-USGS:develop Aug 5, 2023
@wpbonelli wpbonelli deleted the test-target-config branch August 5, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant